Add auth #29
Merged
Add auth #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test ResultsTests: failure Workflow triggered by @AmirAgassi, ran on |
aidantrabs
requested changes
Nov 8, 2024
juancwu
requested changes
Nov 8, 2024
Test ResultsTests: failure Workflow triggered by @AmirAgassi, ran on |
juancwu
requested changes
Nov 9, 2024
juancwu
reviewed
Nov 9, 2024
| return echo.NewHTTPError(http.StatusInternalServerError, "failed to create user") | ||
| } | ||
|
|
||
| userID := convert.UUIDToString(user.ID) |
There was a problem hiding this comment.
Curious why is this needed?
There was a problem hiding this comment.
func generateJWT(userID string, role string) (string, error)
based on his function definition, he changed the UUID to a string to pass it in
There was a problem hiding this comment.
waiiit so like the UUID type is not just an alias to a string? thats dumb
|
why is the action failing? |
it's expecting to connect to the PostgreSQL db, but that isn't implemented in the github action workflow yet 😞 |
|
I am working on updating the workflow |
juancwu
approved these changes
Nov 10, 2024
Test ResultsTests: failure Workflow triggered by @AmirAgassi, ran on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.